chore(dep)!: upgrade gts 2.0.0 #194
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 371 371
Branches 45 42 -3
=====================================
Hits 371 371
Continue to review full report at Codecov.
|
package.json
Outdated
| "codecov": "^3.0.4", | ||
| "gts": "^1.0.0", | ||
| "eslint": "^6.8.0", |
There was a problem hiding this comment.
We can drop all of these eslint dependencies
package.json
Outdated
| "prepare": "npm run compile", | ||
| "pretest": "npm run compile", | ||
| "posttest": "npm run lint", | ||
| "docs": "compodoc src/", | ||
| "presystem-test": "npm run compile", | ||
| "samples-test": "cd samples/ && npm link ../ && npm test && cd ../", | ||
| "samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../", |
There was a problem hiding this comment.
@bcoe do we do this in other places?
There was a problem hiding this comment.
all that should be required is this:
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../"
which is what we use in other libraries, npm link ../ should perform the install.
There was a problem hiding this comment.
FYI: The couple libraries I converted use samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../, like https://github.com/googleapis/nodejs-monitoring/blob/master/package.json#L32
| @@ -47,7 +47,7 @@ export class ResourceStream<T> extends Transform implements ResourceEvents<T> { | |||
| this._requestsMade = 0; | |||
| this._resultsToSend = args.maxResults === -1 ? Infinity : args.maxResults!; | |||
| } | |||
| // tslint:disable-next-line:no-any | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
I think this is fine for now, I would rather that these PRs turn into as minimal of a refactor as possible, even though we might want to come back and make this a more extensive refactor.
upgrade gts 2.0.0
fix some lint issue.