Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not modify options object, use defaultScopes #935

Merged
merged 2 commits into from Nov 6, 2020

Conversation

alexander-fenster
Copy link
Contributor

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • src/v2/config_service_v2_client.ts
  • src/v2/logging_service_v2_client.ts
  • src/v2/metrics_service_v2_client.ts
  • system-test/install.ts

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #935 (1c5e686) into master (e594c9b) will decrease coverage by 0.03%.
The diff coverage is 98.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   98.24%   98.21%   -0.04%     
==========================================
  Files          18       18              
  Lines       10843    10928      +85     
  Branches      378      367      -11     
==========================================
+ Hits        10653    10733      +80     
- Misses        188      193       +5     
  Partials        2        2              
Impacted Files Coverage Δ
src/v2/metrics_service_v2_client.ts 98.37% <96.47%> (-0.04%) ⬇️
src/v2/logging_service_v2_client.ts 98.51% <98.49%> (-0.09%) ⬇️
src/v2/config_service_v2_client.ts 98.70% <98.90%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e594c9b...1c5e686. Read the comment docs.

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fd1e63a into master Nov 6, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@stephenplusplus stephenplusplus deleted the ggt-1.2.1 branch November 11, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants