Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: upgrade engines field to >=8.10.0 #461

Merged
merged 2 commits into from May 2, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 2, 2019

This drops support for all Node.js versions < 8.10.0, please upgrade

BREAKING CHANGE: library now requires Node >= 8.10.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #461 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          10       10           
  Lines         449      449           
  Branches       74       74           
=======================================
  Hits          421      421           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93c988...15c46d3. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 641ce87 into master May 2, 2019
@JustinBeckwith JustinBeckwith deleted the update-engine-field-2-the-updates-revenge branch May 2, 2019 18:30
@evelant
Copy link

evelant commented Jun 27, 2019

This breaks usage with firebase cloud functions. Firebase cloud functions require engines to be "8" or "10" and won't accept any other values. Due to that, this library fails to compile when attempting to deploy cloud functions firebase deploy --only functions with

i  functions: preparing functions directory for uploading...

Error: Error occurred while parsing your function triggers.

Error: @grpc/grpc-js only works on Node ^8.13.0 || >=10.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants