feat: add support for apiEndpoint override #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 4 4
Lines 102 102
Branches 24 24
=======================================
Hits 96 96
Misses 3 3
Partials 3 3Continue to review full report at Codecov.
|
DominicKramer
approved these changes
Jun 21, 2019
|
LGTM but I'll wait to land this to give @bcoe a chance to review it. |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the real work here is done in the
@google-cloud/logginglibrary. We just need to make sure the option is passable to the underlying lib.