fix(docs): pin to version of compodoc that renders JavaScript/tables #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Jun 14, 2019
bcoe
added
the
kokoro:force-run
DominicKramer
approved these changes
Jun 15, 2019
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 4 4
Lines 101 101
Branches 23 23
=======================================
Hits 96 96
Misses 2 2
Partials 3 3Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 4 4
Lines 101 101
Branches 23 23
=======================================
Hits 96 96
Misses 2 2
Partials 3 3Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@compodoc/compodoc@1.1.9fails to render markdown tables and JavaScript code blocks, I've opened a tracking issue here on compodoc:compodoc/compodoc#795
For the time being, pinning to
1.1.8seems to put us in a better position.fixes #335