Typescript: Type 'LoggingWinston[]' is not assignable to type 'TransportStream[]'.

[Lukas-Kullmann]

Environment details

• OS: Ubuntu 18
• Node.js version: 10.16.0
• npm version: 6.9.0
• typscript version: 3.5.1
• winston version: 3.2.1 (also reproducable with 3.1.0)
• @google-cloud/logging-winston version: 1.0.0

Steps to reproduce

It's basically the same issue as #129.

1. Try setting up winston

import { LoggingWinston } from '@google-cloud/logging-winston';
import winston from 'winston';

winston.createLogger({
  transports: [
    new LoggingWinston(),
  ],
});

2. Typescript throws an error

Error:(5,3) TS2322: Type 'LoggingWinston[]' is not assignable to type 'TransportStream | TransportStream[]'.
  Type 'LoggingWinston[]' is not assignable to type 'TransportStream[]'.
    Type 'LoggingWinston' is missing the following properties from type 'TransportStream': writable, writableHighWaterMark, writableLength, _write, and 24 more.

Fix

The problem is that winston-transport defines the export of TransportStream via export =.

Changing the typings of @google-cloud/logging-winston/index.d.ts resolves the problem:

-import * as TransportStream from 'winston-transport';
+import TransportStream = require('winston-transport');

See also the typescript documentation on AMD and CommonJS modules.