fix(middleware): need message in request log message (#349)

googleapis · Jun 18, 2019 · cb11e4c · cb11e4c
1 parent 64fd853
commit cb11e4c
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -126,7 +126,8 @@ app.get('/', (req, res) => {
     // `req.log` can be used as a winston style log method. All logs generated
     // using `req.log` use the current request context. That is, all logs
     // corresponding to a specific request will be bundled in the Stackdriver
-    // UI.
+    // UI. The log method will accept RFC5424 (syslog) log levels (the same
+    // levels provided by winston.config.syslog.levels).
     req.log.info('this is an info log message');
     res.send('hello world');
 });

diff --git a/src/middleware/express.ts b/src/middleware/express.ts
@@ -38,7 +38,7 @@ export async function middleware(options?: MiddlewareOptions) {
   const defaultOptions = {
     logName: 'winston_log',
     level: 'info',
-    levels: winston.config.npm.levels,
+    levels: winston.config.syslog.levels,
   };
   options = Object.assign({}, defaultOptions, options);
 
@@ -71,7 +71,11 @@ export async function middleware(options?: MiddlewareOptions) {
       transports: [loggingWinstonReq],
     });
     emitRequestLog = (httpRequest: HttpRequest, trace: string) => {
-      requestLogger.info({[LOGGING_TRACE_KEY]: trace, httpRequest});
+      requestLogger.info({
+        [LOGGING_TRACE_KEY]: trace,
+        httpRequest,
+        message: httpRequest.requestUrl || 'http request',
+      });
     };
   }
 

diff --git a/system-test/test-middleware-express.ts b/system-test/test-middleware-express.ts
@@ -62,13 +62,26 @@ describe(__filename, () => {
 
         await delay(WRITE_CONSISTENCY_DELAY_MS);
 
-        const log = logging.log(`${LOG_NAME}_applog`);
-        const entries = (await log.getEntries({pageSize: 1}))[0];
-        assert.strictEqual(entries.length, 1);
-        const entry = entries[0];
-        assert.strictEqual(LOG_MESSAGE, entry.data.message);
-        assert(entry.metadata.trace, 'should have a trace property');
-        assert(entry.metadata.trace.match(/projects\/.*\/traces\/.*/));
+        const appLog = logging.log(`${LOG_NAME}_applog`);
+        const appLogEntries = (await appLog.getEntries({pageSize: 1}))[0];
+        assert.strictEqual(appLogEntries.length, 1);
+        const [appLogEntry] = appLogEntries;
+        assert.strictEqual(LOG_MESSAGE, appLogEntry.data.message);
+        assert(appLogEntry.metadata.trace, 'should have a trace property');
+        assert(appLogEntry.metadata.trace.match(/projects\/.*\/traces\/.*/));
+        assert.strictEqual(appLogEntry.metadata.severity, 'INFO');
+
+        const requestLog = logging.log(LOG_NAME);
+        const requestLogEntries = (await requestLog.getEntries({
+          pageSize: 1,
+        }))[0];
+        assert.strictEqual(requestLogEntries.length, 1);
+        const [requestLogEntry] = requestLogEntries;
+        assert.strictEqual(
+          requestLogEntry.metadata.trace,
+          appLogEntry.metadata.trace
+        );
+
         done();
       };