fix: remove path params when provided via API level options #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 71.55% 72.03% +0.48%
==========================================
Files 2 2
Lines 116 118 +2
Branches 35 36 +1
==========================================
+ Hits 83 85 +2
+ Misses 18 16 -2
- Partials 15 17 +2
Continue to review full report at Codecov.
|
bcoe
approved these changes
Jun 21, 2019
src/apirequest.ts
Outdated
| @@ -160,6 +160,9 @@ async function createAPIRequestAsync<T>(parameters: APIRequestParams) { | |||
| // query | |||
| parameters.pathParams.forEach(param => { | |||
| delete params[param]; | |||
| if (parameters.context._options.params) { | |||
There was a problem hiding this comment.
Is it worth being defensive and checking:
if (parameters.context && parameters.context._options && parameters.context._options.params) {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.