Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use deep merge for headers #142

Merged
merged 4 commits into from Jun 14, 2019
Merged

fix: use deep merge for headers #142

merged 4 commits into from Jun 14, 2019

Conversation

JustinBeckwith
Copy link
Contributor

This fixes an upstream bug where headers offered via global options are clobbered and ignored.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@JustinBeckwith JustinBeckwith requested a review from bcoe June 14, 2019 05:15
package.json Outdated
"gaxios": "^2.0.1",
"google-auth-library": "^4.2.0",
"pify": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need pify?

@JustinBeckwith JustinBeckwith merged commit 404fd19 into master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants