Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coreos): handle coreos deprecation #270

Merged
merged 2 commits into from Sep 23, 2020
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Sep 23, 2020

All CoreOs images are now deprecated, which broke some of our logic:

https://cloud.google.com/compute/docs/eol/coreOS

@bcoe bcoe requested a review from a team as a code owner September 23, 2020 18:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #270 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   51.91%   51.66%   -0.25%     
==========================================
  Files           3        3              
  Lines         418      420       +2     
  Branches        6        6              
==========================================
  Hits          217      217              
- Misses        201      203       +2     
Impacted Files Coverage Δ
src/index.ts 51.87% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78438ce...41cc7f8. Read the comment docs.

@bcoe bcoe merged commit 38ec012 into master Sep 23, 2020
@bcoe bcoe deleted the handle-coreos-deprecation branch September 23, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants