Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add google-gax status to exports #912

Merged
merged 6 commits into from Feb 7, 2020
Merged

feat: add google-gax status to exports #912

merged 6 commits into from Feb 7, 2020

Conversation

thebrianchen
Copy link

Fixes #902

@thebrianchen thebrianchen added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Feb 5, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited

Codecov Report

Merging #912 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #912      +/-   ##
=========================================
+ Coverage    96.6%   96.6%   +<.01%     
=========================================
  Files          25      25              
  Lines       15565   15566       +1     
  Branches     1158    1158              
=========================================
+ Hits        15037   15038       +1     
  Misses        519     519              
  Partials        9       9
Impacted Files Coverage Δ
dev/src/index.ts 98.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610f7aa...6759af5. Read the comment docs.

schmidt-sebastian
schmidt-sebastian suggested changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also do the same thing in index.ts to match the types you just generated.

@schmidt-sebastian
Copy link
Contributor

I am also not able to get type completion to work. Look at these two examples:

Screen Shot 2020-02-06 at 1 57 42 PM

Screen Shot 2020-02-06 at 1 58 48 PM

@thebrianchen thebrianchen merged commit 7d97384 into master Feb 7, 2020
@thebrianchen thebrianchen deleted the bc/gax-status branch February 7, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reexport Status from google-gax
3 participants
@thebrianchen @schmidt-sebastian @googlebot