Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not assume all custom objects have constructors #893

Merged
merged 2 commits into from Jan 22, 2020
Merged

fix: do not assume all custom objects have constructors #893

merged 2 commits into from Jan 22, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

fixes #892

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2020
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jan 22, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited

Codecov Report

Merging #893 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #893   +/-   ##
======================================
  Coverage    96.6%   96.6%           
======================================
  Files          25      25           
  Lines       15560   15560           
  Branches     1156    1156           
======================================
  Hits        15032   15032           
  Misses        519     519           
  Partials        9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e63e73...4b31504. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit f668e8e into master Jan 22, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/typeofnull branch June 24, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isMomentJsType - Cannot read property 'name' of undefined
3 participants
@schmidt-sebastian @thebrianchen @googlebot