Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't retry reads with Code ABORTED #881

Merged
merged 3 commits into from Jan 14, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Manual synthtool run to unblock #827

The run last night failed because the pipeline was unable to obtain certificates.

Fixes #878

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #881 into master will increase coverage by 1.7%.
The diff coverage is 99.54%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #881     +/-   ##
========================================
+ Coverage    94.9%   96.6%   +1.7%     
========================================
  Files          25      25             
  Lines       15202   15544    +342     
  Branches     1128    1151     +23     
========================================
+ Hits        14427   15016    +589     
+ Misses        767     519    -248     
- Partials        8       9      +1
Impacted Files Coverage Δ
dev/src/types.ts 100% <100%> (+100%) ⬆️
dev/src/logger.ts 100% <100%> (ø) ⬆️
dev/src/document.ts 98.67% <100%> (-0.01%) ⬇️
dev/src/write-batch.ts 99.57% <100%> (ø) ⬆️
dev/src/serializer.ts 95.32% <100%> (+0.33%) ⬆️
dev/src/document-change.ts 100% <100%> (ø) ⬆️
dev/src/watch.ts 98.26% <100%> (+0.04%) ⬆️
dev/src/reference.ts 98.91% <100%> (-0.16%) ⬇️
dev/src/index.ts 98.44% <96.77%> (-0.06%) ⬇️
dev/src/transaction.ts 96.75% <97.7%> (+0.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2147e...f4f9c3f. Read the comment docs.

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swoooping in to lgtm

@schmidt-sebastian schmidt-sebastian merged commit 82273ec into master Jan 14, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/synthtool branch January 15, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis failed for nodejs-firestore
4 participants