Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry writes that fail with status code ABORTED #854

Merged
merged 2 commits into from Jan 3, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Cloning googleapis.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:5e84faf6ea4136150121182591b5f46e8c7fad75b3a8b4b1b37c41c8f0eff88e
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/firestore/admin/v1.
synthtool > Generated code into /tmpfs/tmp/tmp_w1ym55e.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:5e84faf6ea4136150121182591b5f46e8c7fad75b3a8b4b1b37c41c8f0eff88e
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/firestore/v1beta1.
synthtool > Generated code into /tmpfs/tmp/tmp8c8nvuud.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:5e84faf6ea4136150121182591b5f46e8c7fad75b3a8b4b1b37c41c8f0eff88e
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/firestore/v1.
synthtool > Generated code into /tmpfs/tmp/tmpwc7cdtbr.
synthtool > Replaced 'return this\\._innerApiCalls\\.listen\\(options\\);' in dev/src/v1beta1/firestore_client.ts.
synthtool > Replaced 'return this\\._innerApiCalls\\.listen\\(options\\);' in dev/src/v1/firestore_client.ts.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
synthtool > Replaced "/protos/protos'" in dev/src/v1/firestore_client.ts.
synthtool > Replaced "/protos/protos'" in dev/test/gapic-firestore-v1.ts.
synthtool > Replaced "/protos/protos'" in dev/src/v1/firestore_admin_client.ts.
synthtool > Replaced "/protos/protos'" in dev/test/gapic-firestore_admin-v1.ts.
synthtool > Replaced "/protos/protos'" in dev/src/v1beta1/firestore_client.ts.
synthtool > Replaced "/protos/protos'" in dev/test/gapic-firestore-v1beta1.ts.
npm WARN npm npm does not support Node.js v12.14.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

> core-js@2.6.11 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"


> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/firestore@3.2.0 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.14.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/firestore@3.2.0 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r dev/protos build && cp -r dev/test/fake-certificate.json build/test/fake-certificate.json && cp dev/src/v1beta1/*.json build/src/v1beta1/ && cp dev/src/v1/*.json build/src/v1/ && cp dev/conformance/test-definition.proto build/conformance && cp dev/conformance/test-suite.binproto build/conformance

npm notice created a lockfile as package-lock.json. You should commit this file.
added 651 packages from 932 contributors and audited 1769 packages in 19.618s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.14.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/firestore@3.2.0 fix /tmpfs/src/git/autosynth/working_repo
> gts fix

installing semver@^5.5.0
installing chalk@^2.4.1
installing minimist@^1.2.0
installing uglify-js@^3.3.25
installing espree@^3.5.4
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 3, 2020
@schmidt-sebastian schmidt-sebastian changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. fix: retry writes that fail with status code ABORTED Jan 3, 2020
@schmidt-sebastian
Copy link
Contributor

Fixes #827

@schmidt-sebastian schmidt-sebastian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2020
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #854 into master will increase coverage by 7.97%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
+ Coverage    87.4%   95.37%   +7.97%     
==========================================
  Files          27       25       -2     
  Lines       16542    15151    -1391     
  Branches     1151     1151              
==========================================
- Hits        14458    14450       -8     
+ Misses       2078      695    -1383     
  Partials        6        6
Impacted Files Coverage Δ
dev/src/v1beta1/firestore_client.ts 93.23% <0%> (ø) ⬆️
dev/src/v1/firestore_admin_client.ts 89.96% <25%> (ø) ⬆️
dev/src/v1/firestore_client.ts 94.7% <66.66%> (-0.04%) ⬇️
types/firestore.d.ts
dev/src/external-modules.d.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191d3b8...9efefd1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants