Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase test timeout #846

Merged
merged 1 commit into from Dec 30, 2019
Merged

fix: increase test timeout #846

merged 1 commit into from Dec 30, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

This should make our CI less flaky.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2019
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files          27       27           
  Lines       16769    16769           
  Branches     1156     1156           
=======================================
  Hits        14896    14896           
  Misses       1868     1868           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1445286...1fcd24e. Read the comment docs.

@@ -1073,7 +1073,7 @@ describe('getAll() method', () => {
expect(actualErrorAttempts).to.deep.eq(expectedErrorAttempts);
});
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally do this.timeout(5000); inside the function, it may be more readable than this, but up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't compile for me:

test/watch.ts(865,5): error TS7041: The containing arrow function captures the global value of 'this'.
test/watch.ts(865,10): error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

If I want to do this, I have to use function() {..} somewhere in my test initialization (e.g. in the describe call). Rather than do this, I prefer to leave it as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we use function instead of arrow-style functions if we need to set this.timeout(). That's OK to leave it as is.

@schmidt-sebastian schmidt-sebastian merged commit b94c367 into master Dec 30, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/timeout branch January 3, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants