fix: reduce overhead for listDocuments()/listCollections() #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt/pagesize
branch
2 times, most recently
from
1342323
to
70ff176
Compare
schmidt-sebastian
requested review from
alexander-fenster
and removed request for
mikelehen
schmidt-sebastian
force-pushed
the
mrschmidt/pagesize
branch
from
70ff176
to
c48a1e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 88.83% 88.83% +<.01%
==========================================
Files 27 27
Lines 16716 16725 +9
Branches 1151 1151
==========================================
+ Hits 14849 14858 +9
Misses 1862 1862
Partials 5 5
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
mrschmidt/pagesize
branch
from
c48a1e9
to
3585b8e
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/pagesize
branch
from
3585b8e
to
f3ec6aa
Compare
alexander-fenster
added
the
kokoro:force-run
alexander-fenster
approved these changes
Dec 26, 2019
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the page size from 20 (default) to 300 (max).
Fixes #825