fix: Relax validation of FIRESTORE_EMULATOR_HOST in settings() #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt/settingsthensettings
branch
from
3c7fa9f
to
3344e82
Compare
schmidt-sebastian
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 96.21% 96.08% -0.14%
==========================================
Files 20 20
Lines 2219 2220 +1
Branches 470 470
==========================================
- Hits 2135 2133 -2
- Misses 20 22 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 96.21% 96.08% -0.14%
==========================================
Files 20 20
Lines 2219 2220 +1
Branches 470 470
==========================================
- Hits 2135 2133 -2
- Misses 20 22 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696 (comment)