Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): revert jsdoc and pin to 3.5.5 #627

Merged
merged 1 commit into from May 15, 2019
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented May 15, 2019

This reverts commit 83c5dd9.

fixes #626

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@jkwlui jkwlui requested a review from a team May 15, 2019 20:07
@jkwlui jkwlui self-assigned this May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files          21       21           
  Lines        3409     3409           
  Branches      460      460           
=======================================
  Hits         2095     2095           
  Misses       1252     1252           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c5dd9...4ee2e69. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files          21       21           
  Lines        3409     3409           
  Branches      460      460           
=======================================
  Hits         2095     2095           
  Misses       1252     1252           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c5dd9...4ee2e69. Read the comment docs.

@JustinBeckwith JustinBeckwith changed the title Revert "chore(deps): update dependency jsdoc to v3.6.2 (#619)" fix(deps): revert jsdoc and pin to 3.5.5 May 15, 2019
@JustinBeckwith JustinBeckwith changed the title fix(deps): revert jsdoc and pin to 3.5.5 fix(docs): revert jsdoc and pin to 3.5.5 May 15, 2019
@JustinBeckwith JustinBeckwith merged commit e22f9c6 into master May 15, 2019
@stephenplusplus stephenplusplus deleted the revert-jsdoc-3.6.2 branch May 15, 2019 20:50
schmidt-sebastian added a commit that referenced this pull request May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsdoc is only showing a subset of the classes
3 participants