Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tests to check fields used in whereIn should not be in implicit orderby #1081

Merged
merged 2 commits into from May 14, 2020

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented May 14, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2020
@wu-hui wu-hui requested a review from thebrianchen May 14, 2020 15:13
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #1081 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
- Coverage   97.62%   97.49%   -0.13%     
==========================================
  Files          27       27              
  Lines       16925    16925              
  Branches     1347     1263      -84     
==========================================
- Hits        16523    16501      -22     
- Misses        399      420      +21     
- Partials        3        4       +1     
Impacted Files Coverage Δ
dev/src/order.ts 98.09% <0.00%> (-1.15%) ⬇️
dev/src/pool.ts 97.75% <0.00%> (-0.90%) ⬇️
dev/src/transaction.ts 96.47% <0.00%> (-0.51%) ⬇️
dev/src/watch.ts 98.77% <0.00%> (-0.37%) ⬇️
dev/src/bulk-writer.ts 98.47% <0.00%> (-0.31%) ⬇️
dev/src/document.ts 98.62% <0.00%> (-0.30%) ⬇️
dev/src/validate.ts 98.05% <0.00%> (-0.25%) ⬇️
dev/src/serializer.ts 98.81% <0.00%> (-0.24%) ⬇️
dev/src/write-batch.ts 99.89% <0.00%> (-0.11%) ⬇️
dev/src/reference.ts 99.80% <0.00%> (-0.08%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f14d2...432d54d. Read the comment docs.

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@thebrianchen thebrianchen assigned wu-hui and unassigned thebrianchen May 14, 2020
@wu-hui wu-hui merged commit 3153dd2 into master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants