Navigation Menu

Skip to content

Commit

Permalink
fix: proper routing headers
Browse files Browse the repository at this point in the history
  • Loading branch information
@yoshi-automation @alexander-fenster
yoshi-automation authored and alexander-fenster committed Jan 9, 2020
1 parent f17d90e commit 43472f6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 298 deletions.
2 changes: 1 addition & 1 deletion dev/src/v1/firestore_client.ts
View file
Expand Up @@ -550,7 +550,7 @@ export class FirestoreClient {
options.otherArgs.headers[
'x-goog-request-params'
] = gax.routingHeader.fromParams({
document_name: request.document!.name || '',
'document.name': request.document!.name || '',
});
return this._innerApiCalls.updateDocument(request, options, callback);
}
Expand Down
2 changes: 1 addition & 1 deletion dev/src/v1beta1/firestore_client.ts
View file
Expand Up @@ -560,7 +560,7 @@ export class FirestoreClient {
options.otherArgs.headers[
'x-goog-request-params'
] = gax.routingHeader.fromParams({
document_name: request.document!.name || '',
'document.name': request.document!.name || '',
});
return this._innerApiCalls.updateDocument(request, options, callback);
}
Expand Down
299 changes: 3 additions & 296 deletions dev/synth.metadata
View file
@@ -1,12 +1,12 @@
{
"updateTime": "2020-01-03T12:14:28.989140Z",
"updateTime": "2020-01-09T12:16:06.483557Z",
"sources": [
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "4d45a6399e9444fbddaeb1c86aabfde210723714",
"internalRef": "287908369"
"sha": "6ace586805c08896fef43e28a261337fcf3f022b",
"internalRef": "288783603"
}
},
{
Expand Down Expand Up @@ -45,298 +45,5 @@
"generator": "gapic-generator-typescript"
}
}
],
"newFiles": [
{
"path": "synth.metadata"
},
{
"path": "test/path.ts"
},
{
"path": "test/gapic-firestore-v1beta1.ts"
},
{
"path": "test/fake-certificate.json"
},
{
"path": "test/gapic-firestore-v1.ts"
},
{
"path": "test/pool.ts"
},
{
"path": "test/mocha.opts"
},
{
"path": "test/timestamp.ts"
},
{
"path": "test/document.ts"
},
{
"path": "test/index.ts"
},
{
"path": "test/query.ts"
},
{
"path": "test/watch.ts"
},
{
"path": "test/backoff.ts"
},
{
"path": "test/gapic-firestore_admin-v1.ts"
},
{
"path": "test/collection.ts"
},
{
"path": "test/field-value.ts"
},
{
"path": "test/order.ts"
},
{
"path": "test/typescript.ts"
},
{
"path": "test/transaction.ts"
},
{
"path": "test/write-batch.ts"
},
{
"path": "test/util/helpers.ts"
},
{
"path": "system-test/.gitignore"
},
{
"path": "system-test/firestore.ts"
},
{
"path": "system-test/.eslintrc.yml"
},
{
"path": "protos/firestore_admin_v1_proto_api.d.ts"
},
{
"path": "protos/update.sh"
},
{
"path": "protos/firestore_v1beta1_proto_api.js"
},
{
"path": "protos/firestore_v1_proto_api.d.ts"
},
{
"path": "protos/firestore_v1_proto_api.js"
},
{
"path": "protos/protos.json"
},
{
"path": "protos/firestore_v1beta1_proto_api.d.ts"
},
{
"path": "protos/firestore_admin_v1_proto_api.js"
},
{
"path": "protos/google/api/http.proto"
},
{
"path": "protos/google/api/annotations.proto"
},
{
"path": "protos/google/api/field_behavior.proto"
},
{
"path": "protos/google/api/resource.proto"
},
{
"path": "protos/google/api/client.proto"
},
{
"path": "protos/google/type/latlng.proto"
},
{
"path": "protos/google/protobuf/field_mask.proto"
},
{
"path": "protos/google/protobuf/struct.proto"
},
{
"path": "protos/google/protobuf/empty.proto"
},
{
"path": "protos/google/protobuf/any.proto"
},
{
"path": "protos/google/protobuf/wrappers.proto"
},
{
"path": "protos/google/protobuf/timestamp.proto"
},
{
"path": "protos/google/longrunning/operations.proto"
},
{
"path": "protos/google/rpc/status.proto"
},
{
"path": "protos/google/firestore/v1beta1/firestore.proto"
},
{
"path": "protos/google/firestore/v1beta1/common.proto"
},
{
"path": "protos/google/firestore/v1beta1/query.proto"
},
{
"path": "protos/google/firestore/v1beta1/write.proto"
},
{
"path": "protos/google/firestore/v1beta1/document.proto"
},
{
"path": "protos/google/firestore/admin/v1/location.proto"
},
{
"path": "protos/google/firestore/admin/v1/index.proto"
},
{
"path": "protos/google/firestore/admin/v1/firestore_admin.proto"
},
{
"path": "protos/google/firestore/admin/v1/operation.proto"
},
{
"path": "protos/google/firestore/admin/v1/field.proto"
},
{
"path": "protos/google/firestore/v1/firestore.proto"
},
{
"path": "protos/google/firestore/v1/common.proto"
},
{
"path": "protos/google/firestore/v1/query.proto"
},
{
"path": "protos/google/firestore/v1/write.proto"
},
{
"path": "protos/google/firestore/v1/document.proto"
},
{
"path": "src/path.ts"
},
{
"path": "src/util.ts"
},
{
"path": "src/reference.ts"
},
{
"path": "src/logger.ts"
},
{
"path": "src/types.ts"
},
{
"path": "src/geo-point.ts"
},
{
"path": "src/pool.ts"
},
{
"path": "src/timestamp.ts"
},
{
"path": "src/document.ts"
},
{
"path": "src/convert.ts"
},
{
"path": "src/index.ts"
},
{
"path": "src/validate.ts"
},
{
"path": "src/serializer.ts"
},
{
"path": "src/watch.ts"
},
{
"path": "src/backoff.ts"
},
{
"path": "src/external-modules.d.ts"
},
{
"path": "src/field-value.ts"
},
{
"path": "src/order.ts"
},
{
"path": "src/document-change.ts"
},
{
"path": "src/transaction.ts"
},
{
"path": "src/write-batch.ts"
},
{
"path": "src/v1beta1/index.ts"
},
{
"path": "src/v1beta1/firestore_client.ts"
},
{
"path": "src/v1beta1/firestore_client_config.json"
},
{
"path": "src/v1beta1/firestore_proto_list.json"
},
{
"path": "src/v1/index.ts"
},
{
"path": "src/v1/firestore_client.ts"
},
{
"path": "src/v1/firestore_client_config.json"
},
{
"path": "src/v1/firestore_admin_client_config.json"
},
{
"path": "src/v1/firestore_admin_client.ts"
},
{
"path": "src/v1/firestore_admin_proto_list.json"
},
{
"path": "src/v1/firestore_proto_list.json"
},
{
"path": "conformance/test-definition.proto"
},
{
"path": "conformance/runner.ts"
},
{
"path": "conformance/test-suite.binproto"
},
{
"path": "conformance/.eslintrc.yml"
}
]
}

0 comments on commit 43472f6

Please sign in to comment.