Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: retry streaming methods if initial write errored (#897)
According to https://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback, the write() callback may be called with an Error before on('error') is invoked. In this case, we should reject our Stream. In the current implementation, we would accept the Stream as healthy and then forward the error to the user, which prevents retries. I noticed while looking at this code as we are porting it to Python
- Loading branch information
1 parent
703cef9
commit 2ec0489
Showing
1 changed file
with
19 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters