Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): cast Object.assign value to ServiceOptions #483

Merged
merged 1 commit into from
May 27, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 27, 2020

Fixes #481

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #483 into master will decrease coverage by 16.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #483       +/-   ##
===========================================
- Coverage   96.01%   79.01%   -17.00%     
===========================================
  Files          21       21               
  Lines        3112     3112               
  Branches      246      224       -22     
===========================================
- Hits         2988     2459      -529     
- Misses        123      651      +528     
- Partials        1        2        +1     
Impacted Files Coverage Δ
src/google-apis/auth-client.ts 71.00% <100.00%> (-21.85%) ⬇️
src/interfaces/message-builder.ts 0.00% <0.00%> (-100.00%) ⬇️
src/index.ts 0.00% <0.00%> (-98.71%) ⬇️
utils/errors-api-transport.ts 0.00% <0.00%> (-91.36%) ⬇️
src/interfaces/koa2.ts 0.00% <0.00%> (-78.88%) ⬇️
src/interfaces/koa.ts 0.00% <0.00%> (-71.43%) ⬇️
src/interfaces/manual.ts 95.88% <0.00%> (-4.12%) ⬇️
src/logger.ts 87.35% <0.00%> (-2.30%) ⬇️
src/configuration.ts 96.23% <0.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d2499...e6ca953. Read the comment docs.

@bcoe bcoe merged commit cfee918 into master May 27, 2020
@bcoe bcoe deleted the fix-compile branch May 27, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis failed for nodejs-error-reporting
3 participants