Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library should automatically pick up service and revision name in Knative environments #370

Closed
steren opened this issue Jun 1, 2019 · 1 comment · Fixed by #375
Closed

Library should automatically pick up service and revision name in Knative environments #370

steren opened this issue Jun 1, 2019 · 1 comment · Fixed by #375
Assignees
@DominicKramer
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@steren
Copy link

steren commented Jun 1, 2019

When running on Cloud Run, or Cloud Run on GKE or any Knative install, the library should pick up the K_SERVICE env var and associate it to the "service" and the K_REVISION env var and associate it to "version".

These env vars are part of the Knative runtime contract, see here

cc @ofrobots
@DominicKramer DominicKramer added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 3, 2019
@DominicKramer
Copy link
Contributor

Thanks for letting us know about this.

@DominicKramer DominicKramer self-assigned this Jun 18, 2019
@DominicKramer DominicKramer mentioned this issue Jun 18, 2019
Merged
DominicKramer added a commit that referenced this issue Jun 19, 2019
@DominicKramer
feat: automatically use service and revision name in Knative environm…
453bd6e 
…ents (#375)

Fixes #370
@google-cloud-label-sync google-cloud-label-sync bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Jan 31, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominicKramer DominicKramer

Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@steren @DominicKramer @yoshi-automation