Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement restore table to a different instance feature (#830) #863

Merged
merged 4 commits into from May 4, 2021

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Apr 27, 2021

  • feat: implement restore table to a different instance feature

  • chore: docs

  • chore: add system test

  • fix(samples): region tag

  • fix: docs

* feat: implement restore table to a different instance feature

* chore: docs

* chore: add system test

* fix(samples): region tag

* fix: docs
@kolea2 kolea2 requested review from a team as code owners April 27, 2021 14:30
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Apr 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2021
@snippet-bot
Copy link

snippet-bot bot commented Apr 27, 2021

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kolea2
Copy link
Contributor Author

kolea2 commented Apr 27, 2021

@liubonan fyi

@kolea2 kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #863 (627591b) into master (0ef8976) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          18       18           
  Lines       17416    17496   +80     
  Branches     1025      960   -65     
=======================================
+ Hits        17281    17361   +80     
  Misses        132      132           
  Partials        3        3           
Impacted Files Coverage Δ
src/app-profile.ts 99.59% <100.00%> (ø)
src/backup.ts 100.00% <100.00%> (ø)
src/cluster.ts 99.72% <100.00%> (ø)
src/family.ts 99.58% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/instance.ts 100.00% <100.00%> (ø)
src/row.ts 100.00% <100.00%> (ø)
src/table.ts 99.89% <100.00%> (ø)
src/v2/bigtable_client.ts 96.55% <100.00%> (ø)
src/v2/bigtable_instance_admin_client.ts 98.79% <100.00%> (+<0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9298365...627591b. Read the comment docs.

@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 30, 2021
Copy link

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of BigTable magic I can't say much about, but this looks good to me on a Node front.

One interesting observation around loading instances from... an Id? To get back to its name? That was a bit unclear.

src/backup.ts Show resolved Hide resolved
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c900b0a into master May 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the backup-different-instance branch May 4, 2021 18:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants