Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: getAppProfilesStream emits (if there are any failed locations present) decorated error with failedLocations info #795

Merged
merged 3 commits into from Sep 3, 2020
Merged

feat: getAppProfilesStream emits (if there are any failed locations present) decorated error with failedLocations info #795

merged 3 commits into from Sep 3, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Sep 3, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@AVaksman AVaksman requested a review from a team as a code owner September 3, 2020 05:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited

Codecov Report

Merging #795 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          17       17           
  Lines       15947    15974   +27     
  Branches      898      966   +68     
=======================================
+ Hits        15811    15838   +27     
  Misses        133      133           
  Partials        3        3
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/instance.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb77d56...f2b0d00. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Sep 3, 2020
stephenplusplus
stephenplusplus reviewed Sep 3, 2020
View reviewed changes
src/instance.ts Outdated Show resolved Hide resolved
@bcoe bcoe merged commit dbb19fe into googleapis:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AVaksman @stephenplusplus @bcoe