Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect pageSize and pageToken from gaxOptions #781

Merged
merged 1 commit into from Aug 7, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Aug 3, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Changes

  • Expose pageSize and pageToken in getTablesOptions
  • Respect pageSize and pageToken passed from gaxOptions
  • Values passed in options take precedence vs values from gaxOptions

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #781 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #781   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          17       17           
  Lines       15886    15944   +58     
  Branches      892      965   +73     
=======================================
+ Hits        15750    15808   +58     
  Misses        133      133           
  Partials        3        3           
Impacted Files Coverage Δ
src/instance.ts 100.00% <100.00%> (ø)
src/table.ts 99.63% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c03f5...6d7e372. Read the comment docs.

@AVaksman AVaksman marked this pull request as ready for review August 3, 2020 17:44
@AVaksman AVaksman requested a review from a team as a code owner August 3, 2020 17:44
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would lean towards calling this a fix:.

Even though this is technically a breaking change, I think given the prior behavior was obviously a bug, I'm comfortable landing as patch.

Would be curious if any other folks have thoughts though.

@AVaksman AVaksman changed the title feat: respect pageSize and pageToken from gaxOptions fix: respect pageSize and pageToken from gaxOptions Aug 4, 2020
@AVaksman
Copy link
Contributor Author

AVaksman commented Aug 4, 2020

It shouldn't break an existing code, I believe.

@bcoe bcoe merged commit 3ca5de3 into googleapis:master Aug 7, 2020
@bcoe
Copy link
Contributor

bcoe commented Aug 7, 2020

@AVaksman thank you 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants