Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): stricter types are now enforced #733

Merged
merged 1 commit into from May 27, 2020
Merged

fix(types): stricter types are now enforced #733

merged 1 commit into from May 27, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 27, 2020

Fixes #730

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #733 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          15       15           
  Lines       15723    15723           
  Branches      955      958    +3     
=======================================
  Hits        15594    15594           
  Misses        126      126           
  Partials        3        3           
Impacted Files Coverage Δ
src/instance.ts 99.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998dc4b...fd1be4c. Read the comment docs.

@bcoe bcoe merged commit dfd22a2 into master May 27, 2020
@bcoe bcoe deleted the fix-types branch May 27, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synthesis failed for nodejs-bigtable
3 participants