Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cloud functions example for Bigtable #728

Merged
merged 9 commits into from May 11, 2020
Merged

feat: Cloud functions example for Bigtable #728

merged 9 commits into from May 11, 2020

Conversation

billyjacobson
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020 •
edited

Codecov Report

Merging #728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          15       15           
  Lines       15723    15723           
  Branches      888      955   +67     
=======================================
  Hits        15594    15594           
  Misses        126      126           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31031f2...3e8ae67. Read the comment docs.

@billyjacobson billyjacobson changed the title Cloud functions example for Bigtable feat: Cloud functions example for Bigtable May 11, 2020
@billyjacobson
Copy link
Contributor Author

question about npm run lint, on the CI tests it seems to be able to find the samples/functions directory, but when I run it locally it wasn't linting those files

bcoe
bcoe suggested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, having the nested functions/package.json is causing some issues for linting. If we don't actually reference this package.json on cloud.google.com, could we collapse the deps into samples/package.json?

samples/functions/test/index.test.js Outdated Show resolved Hide resolved
samples/functions/package.json Show resolved Hide resolved
samples/functions/package.json Show resolved Hide resolved
@billyjacobson
reorganize code and lint
abce75a
@billyjacobson
Merge branch 'master' into function-samples
08888dd 
# Conflicts:
#	samples/functions/index.js
#	samples/functions/package.json
#	samples/readSnippets.js
@billyjacobson
Move functions test
8096cca
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2020
@billyjacobson billyjacobson merged commit 95a5db4 into master May 11, 2020
@bcoe bcoe deleted the function-samples branch May 11, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@billyjacobson @bcoe @googlebot @yoshi-kokoro