Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop node8 support, support for async iterators #682

Merged
merged 7 commits into from Apr 2, 2020

Conversation

alexander-fenster
Copy link
Contributor

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #682 into master will increase coverage by 2.80%.
The diff coverage is 99.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   96.20%   99.00%   +2.80%     
==========================================
  Files          15       15              
  Lines       14490    15136     +646     
  Branches      872      932      +60     
==========================================
+ Hits        13940    14986    +1046     
+ Misses        547      147     -400     
  Partials        3        3              
Impacted Files Coverage Δ
src/index.ts 99.79% <90.90%> (-0.21%) ⬇️
src/v2/bigtable_table_admin_client.ts 98.34% <99.34%> (+6.46%) ⬆️
src/v2/bigtable_instance_admin_client.ts 98.21% <99.70%> (+7.70%) ⬆️
src/filter.ts 100.00% <100.00%> (ø)
src/instance.ts 99.82% <100.00%> (ø)
src/mutation.ts 100.00% <100.00%> (ø)
src/row.ts 100.00% <100.00%> (ø)
src/table.ts 99.84% <100.00%> (+<0.01%) ⬆️
src/v2/bigtable_client.ts 96.10% <100.00%> (+4.84%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d9506...a35125d. Read the comment docs.

@bcoe bcoe merged commit 2834e93 into master Apr 2, 2020
@bcoe bcoe deleted the finally-drop-node8 branch April 2, 2020 02:25
@release-please release-please bot mentioned this pull request Apr 2, 2020
@release-please release-please bot mentioned this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants