fix: cluster id store as undefined in createInstance request #654

laljikanjareeya · 2020-03-19T11:40:19Z

Fixes #652

test/index.ts

src/index.ts

stephenplusplus · 2020-03-23T11:55:16Z

LGTM. Thank you!

fix: cluster id store as undefined

2c94d72

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020

laljikanjareeya requested a review from stephenplusplus March 19, 2020 11:41

laljikanjareeya changed the title ~~fix: cluster id store as undefined~~ fix: cluster id store as undefined in createInstance request Mar 19, 2020

stephenplusplus suggested changes Mar 19, 2020

View reviewed changes

test/index.ts Outdated Show resolved Hide resolved

Lalji Kanjareeya added 2 commits March 20, 2020 09:58

Merge branch 'master' into create-instance-cluster-issue

eb27d6f

fix: review changes

459386e

laljikanjareeya requested a review from stephenplusplus March 20, 2020 05:40

stephenplusplus suggested changes Mar 20, 2020

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

Merge branch 'master' into create-instance-cluster-issue

d428e22

JustinBeckwith added the needs work This is a pull request that needs a little love. label Mar 21, 2020

Lalji Kanjareeya added 2 commits March 23, 2020 11:07

Merge branch 'master' into create-instance-cluster-issue

479fe34

fix: review chanages

0aacb37

laljikanjareeya removed the needs work This is a pull request that needs a little love. label Mar 23, 2020

laljikanjareeya requested a review from stephenplusplus March 23, 2020 06:42

stephenplusplus approved these changes Mar 23, 2020

View reviewed changes

laljikanjareeya merged commit 809c719 into googleapis:master Mar 23, 2020

Provide feedback