fix: improve TypeScript types #646
Conversation
googlebot
added
the
cla: yes
| @@ -156,7 +160,7 @@ export class Filter { | |||
| * // startTest2Exclusive: 'value3' | |||
| * // } | |||
| */ | |||
| static createRange(start, end, key) { | |||
| static createRange(start, end, key: string) { | |||
There was a problem hiding this comment.
looks like... Pascal. What are the types for start and end? :)
There was a problem hiding this comment.
Added some cheap well know ones first. This library is a trip man. Will come back around for completeness again.
| @@ -894,23 +892,22 @@ export class Filter { | |||
| * } | |||
| * ]; | |||
| */ | |||
| value(value) { | |||
| value(value): void { | |||
There was a problem hiding this comment.
missing type for the parameter
| @@ -917,5 +948,4 @@ promisifyAll(Bigtable, { | |||
| module.exports = Bigtable; | |||
There was a problem hiding this comment.
This is unrelated, but I don't like this :) We can change this to proper TypeScript exports.
|
Trying to do this bit by bit :) I find the larger the PR the less likely it is to work 😂 But yeah, noImplicitAny coming in like a 5 PR set. |
JustinBeckwith
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 96.31% 96.33% +0.02%
==========================================
Files 15 15
Lines 12818 12892 +74
Branches 802 799 -3
==========================================
+ Hits 12346 12420 +74
Misses 469 469
Partials 3 3
Continue to review full report at Codecov.
|
No description provided.