Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): cluster option name must be id #642

Merged
merged 3 commits into from Mar 18, 2020
Merged

fix(docs): cluster option name must be id #642

merged 3 commits into from Mar 18, 2020

Conversation

laljikanjareeya
Copy link
Contributor

Fixes #640

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2020
@bcoe
Copy link
Contributor

bcoe commented Mar 17, 2020

@laljikanjareeya this seems to be breaking a sample test:

Failed to read: projects/{1046198160504}/instances/nodejs-bigtable-samples-keepme/tables/mobile-time-series

@laljikanjareeya laljikanjareeya merged commit 838837c into googleapis:master Mar 18, 2020
@laljikanjareeya laljikanjareeya mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs mention cluster option "name", must be "id"
4 participants
@laljikanjareeya @bcoe @JustinBeckwith @googlebot