-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to Typescript code generation #631
Conversation
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
===========================================
+ Coverage 73.13% 96.22% +23.08%
===========================================
Files 33 15 -18
Lines 15964 12499 -3465
Branches 586 786 +200
===========================================
+ Hits 11676 12027 +351
+ Misses 4288 469 -3819
- Partials 0 3 +3
Continue to review full report at Codecov.
|
Send out cl/299452868 for fixing the timeout setting in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but we should loop in @steffnay as well.
Given the popularity of this library, I would love to see if someone like Steffany who's familiar with the library could help smoke test a bit, or recommend some smoke testing we could perform.
@xiaozhenliu-gg5 @bcoe This looks good to me. I'm actually not super familiar with this library, though, so I don't think I can be much help with the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xiaozhenliu-gg5 Please remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
No description provided.