feat: implement instance and table level IAM policy #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
approved these changes
Nov 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 86.82% 87.24% +0.41%
==========================================
Files 33 33
Lines 1981 2046 +65
Branches 349 373 +24
==========================================
+ Hits 1720 1785 +65
Misses 233 233
Partials 28 28
Continue to review full report at Codecov.
|
|
@crwilcox I added implementation for Instance level Iam policy and documents snippets. |
kolea2
approved these changes
Nov 25, 2019
AVaksman
changed the title
AVaksman
force-pushed
the
table_level_IAM_controls
branch
from
a3c83f5
to
7c6979c
Compare
billyjacobson
pushed a commit
that referenced
this pull request
Nov 27, 2019
* feat: add table level IAM policy controls * lint: lint * feat: add instance level IAM policy * docs: update description * docs: add document snippets * lint: lint
billyjacobson
added a commit
that referenced
this pull request
Dec 3, 2019
* Reads and filters WIP, working Reads tests and current format for Reads snippets * working tests for solo filters * Composing filters * add bulk region tags * Change testing instance * Linted * feat: implement instance and table level IAM policy (#584) * feat: add table level IAM policy controls * lint: lint * feat: add instance level IAM policy * docs: update description * docs: add document snippets * lint: lint * Linted Fixed headers Removed unnceccessary asyncs Arrow functions where possible * Arrow functions * destructure Bigtable require * Using snapshots for testing * Change functions to use a switch * Fix timezone issue for tests * Lint snapshot files * Clean up loops, add update snapshot method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new features allow user to check and tune IAM policy for the resource (
instance,table) level:getIamPolicy- allows a user obtain the current resource IAM policy.setIamPolicy- allows a user to set resource level IAM policy.testIamPermissions- allows a user to pass a list ofpermissionsand get back a sub-list of granted permissions.Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #581