-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load protos from JSON, grpc-fallback support, IAM protos #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 4, 2019
callmehiphop
changed the title
[CHANGE ME] Re-generated to pick up changes in the API or client library generator.
feat: iam policy support
Sep 4, 2019
callmehiphop
approved these changes
Sep 4, 2019
callmehiphop
changed the title
feat: iam policy support
feat: iam policy support & load protos from JSON, grpc-fallback support
Sep 4, 2019
callmehiphop
changed the title
feat: iam policy support & load protos from JSON, grpc-fallback support
feat: iam policy support & grpc-fallback support
Sep 4, 2019
callmehiphop
changed the title
feat: iam policy support & grpc-fallback support
feat: iam policy & grpc-fallback support
Sep 4, 2019
callmehiphop
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 4, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 10 10
Lines 1313 1313
Branches 347 347
=======================================
Hits 1284 1284
Partials 29 29 Continue to review full report at Codecov.
|
callmehiphop
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 5, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 5, 2019
alexander-fenster
changed the title
feat: iam policy & grpc-fallback support
feat: load protos from JSON, grpc-fallback support, IAM protos
Sep 7, 2019
alexander-fenster
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 7, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 7, 2019
@jkwlui I fixed the proto stuff but the samples test failure does not look related, what do you think? |
callmehiphop
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 9, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: