-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): Include TypeScript types with module #527
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! That flag is set upstream in gts
, so we are emitting a d.ts
file. What we aren't doing, is including the d.ts
in the final npm package. To do that, we need to link to the types file in package.json
. Here's an example:
https://github.com/googleapis/nodejs-storage/blob/master/package.json#L12
Mind taking a look at making that change?
@JustinBeckwith I wouldn't know what it is upstream, I assume it's the same filename? |
It should look exactly like the line I pointed to above :) |
Well in that case that change has been made! |
This reverts commit 224547c.
Should be ready to merge, undid the type fixes for some of the exists() calls as to not have this do more than the original PR title. @JustinBeckwith |
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 10 10
Lines 1313 1313
Branches 347 347
=======================================
Hits 1284 1284
Partials 29 29 Continue to review full report at Codecov.
|
Fixes #526