Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Include TypeScript types with module #527

Merged
merged 6 commits into from Aug 5, 2019
Merged

fix(types): Include TypeScript types with module #527

merged 6 commits into from Aug 5, 2019

Conversation

csidell-earny
Copy link
Contributor

Fixes #526

  • [ X ] Tests and linter pass
  • [ X ] Code coverage does not decrease (if any source code was changed)
  • [ X ] Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 2, 2019
@csidell-earny
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 2, 2019
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! That flag is set upstream in gts, so we are emitting a d.ts file. What we aren't doing, is including the d.ts in the final npm package. To do that, we need to link to the types file in package.json. Here's an example:
https://github.com/googleapis/nodejs-storage/blob/master/package.json#L12

Mind taking a look at making that change?

@csidell-earny
Copy link
Contributor Author

@JustinBeckwith I wouldn't know what it is upstream, I assume it's the same filename?

@JustinBeckwith
Copy link
Contributor

It should look exactly like the line I pointed to above :)

@csidell-earny
Copy link
Contributor Author

Well in that case that change has been made!

@csidell-earny
Copy link
Contributor Author

Should be ready to merge, undid the type fixes for some of the exists() calls as to not have this do more than the original PR title. @JustinBeckwith

@JustinBeckwith JustinBeckwith changed the title Emit definition files on compile fix(types): Include TypeScript types with module Aug 5, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files          10       10           
  Lines        1313     1313           
  Branches      347      347           
=======================================
  Hits         1284     1284           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec5ab3...afa7621. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit cd9e517 into googleapis:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit typescript types on build
4 participants