Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support apiEndpoint override #500

Merged
merged 2 commits into from Jun 21, 2019
Merged

feat: support apiEndpoint override #500

merged 2 commits into from Jun 21, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jun 18, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
callmehiphop
callmehiphop suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a fixy!

@callmehiphop callmehiphop changed the title build: switch to GitHub magic proxy, for release-please feat: support apiEndpoint override Jun 18, 2019
@codecov
Copy link

codecov bot commented Jun 18, 2019 •
edited

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          10       10           
  Lines        1303     1303           
  Branches      345      345           
=======================================
  Hits         1275     1275           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f6f7e...98d8285. Read the comment docs.

@bcoe bcoe requested a review from callmehiphop June 20, 2019 23:48
@JustinBeckwith JustinBeckwith merged commit 89124f6 into master Jun 21, 2019
@stephenplusplus stephenplusplus deleted the magic-proxy branch June 21, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoe @JustinBeckwith @callmehiphop @googlebot