New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selectedFields on getRows not working correctly #712
Conversation
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
=======================================
Coverage 95.16% 95.17%
=======================================
Files 7 7
Lines 6311 6341 +30
Branches 369 371 +2
=======================================
+ Hits 6006 6035 +29
- Misses 305 306 +1
Continue to review full report at Codecov.
|
Looks good to me. Pending second review from @stephenplusplus |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Fixes #702
Data from Back-end is retrieving correctly, but mapping of the data with the schema fields has an issue.
On below line schema fields and data mapping is based on index so, it will map always first property even if user doesn't selected that property.
nodejs-bigquery/src/bigquery.ts
Line 387 in 93945dd
Solution:
Back-end data is retrieving same order as schema fields order, solution for this is to filter schema based on selected fields when
selectedFields
is provided by user.