Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(userAgent): allow for optional user agent to be provided #671

Merged
merged 6 commits into from Jun 9, 2020

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Apr 10, 2020

Allows for optional user agent to be provided to better track usage. Updates @google-cloud/common dependency to version 3.1.0 to use provided user agent feature.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #10

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #671 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files           7        7           
  Lines        6304     6307    +3     
  Branches      406      369   -37     
=======================================
+ Hits         5999     6002    +3     
  Misses        305      305           
Impacted Files Coverage Δ
src/bigquery.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30064a7...7906a6d. Read the comment docs.

@steffnay steffnay added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 10, 2020
@steffnay steffnay changed the title [DO NOT MERGE] feat(userAgent): allow for optional user agent to be provided feat(userAgent): allow for optional user agent to be provided Jun 9, 2020
@steffnay steffnay merged commit 25aeca8 into master Jun 9, 2020
@steffnay steffnay deleted the user-agent branch June 9, 2020 23:16
@steffnay steffnay removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery: set user-agent
3 participants