New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): add retries for insert partial failures #589
Conversation
callmehiphop
commented
Dec 9, 2019
•
edited by zamnuts
edited by zamnuts
- Ensure the tests and linter pass
- Code coverage does not decrease (if any source code was changed)
- Appropriate docs were updated (if necessary)
@callmehiphop is there an issue or internal document related to this, curious to have a bitt of background. |
@bcoe b/145598828 is the internal issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable approach (finite retry when there are entries in the structured error response from invoking tabledata.insertAll).
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 95.10% 95.13% +0.02%
==========================================
Files 7 7
Lines 6214 6290 +76
Branches 397 388 -9
==========================================
+ Hits 5910 5984 +74
- Misses 304 306 +2
Continue to review full report at Codecov.
|
@googlebot I consent |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Waiting on changes from #647 to resolve codecov decrease and to remove test TODO |
I defer my review to Steffany and Ben
…ow retry of 0, do not allow negative retries #589
…ow retry of 0, do not allow negative retries #589