Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JWTInput as a valid type of the options for BigQuery constructor #1199

Open
IvanaGyro opened this issue Apr 3, 2023 · 0 comments
Open

Add JWTInput as a valid type of the options for BigQuery constructor #1199

IvanaGyro opened this issue Apr 3, 2023 · 0 comments
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@IvanaGyro
Copy link

IvanaGyro commented Apr 3, 2023 •
edited

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

  1. Is this a client library issue or a product issue?
    client library

  2. Did someone already solve this?
    No

  3. Do you have a support contract?
    No

If the support paths suggested above still do not result in a resolution, please provide the following details.

Environment details

  • OS: Windows WSL (Ubuntu 22.04)
  • Node.js version: 18.15.0
  • npm version: yarn v1.22.19
  • @google-cloud/bigquery version: 6.2.0

Steps to reproduce

In the example of user auth, an object passed to BigQuery's constructor is not defined in the type definition of this repository. I found there is a similar type JWTInput defined in google-auth-library-nodejs. Can JWTInput be added as a member of BigQueryOptions to make the logic implementation consistent with the type definition?
@IvanaGyro IvanaGyro added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 3, 2023
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Apr 3, 2023
@shollyman shollyman added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 6, 2023
@loferris loferris self-assigned this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shollyman @IvanaGyro @loferris