From 30064a784ac13fe33fbfadbf6fee0ffa133db160 Mon Sep 17 00:00:00 2001
From: Steffany Brown <30247553+steffnay@users.noreply.github.com>
Date: Tue, 9 Jun 2020 12:03:41 -0700
Subject: [PATCH] docs(samples): updates test resource naming to improve
 traceability (#713)

* docs(samples): updates test resource naming to improve traceability

* linted
---
 samples/test/datasets.test.js   |  5 ++++-
 samples/test/jobs.test.js       |  1 -
 samples/test/models.test.js     | 20 ++++++++++++++++----
 samples/test/queries.test.js    |  3 ++-
 samples/test/quickstart.test.js |  5 ++++-
 samples/test/tables.test.js     |  3 ++-
 6 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/samples/test/datasets.test.js b/samples/test/datasets.test.js
index 6d74d0b6..29e60a33 100644
--- a/samples/test/datasets.test.js
+++ b/samples/test/datasets.test.js
@@ -22,7 +22,10 @@ const uuid = require('uuid');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
+const datasetId = `nodejs_samples_tests_datasets_${uuid.v4()}`.replace(
+  /-/gi,
+  '_'
+);
 const bigquery = new BigQuery();
 
 describe('Datasets', () => {
diff --git a/samples/test/jobs.test.js b/samples/test/jobs.test.js
index 4cdd78c8..7f1e03a2 100644
--- a/samples/test/jobs.test.js
+++ b/samples/test/jobs.test.js
@@ -21,7 +21,6 @@ const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-// const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
 const bigquery = new BigQuery();
 let jobId;
 
diff --git a/samples/test/models.test.js b/samples/test/models.test.js
index 960ad4d8..a958ceb1 100644
--- a/samples/test/models.test.js
+++ b/samples/test/models.test.js
@@ -25,8 +25,14 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 const bigquery = new BigQuery();
 
 describe('Models', () => {
-  const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
-  const modelId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
+  const datasetId = `nodejs_samples_tests_models_${uuid.v4()}`.replace(
+    /-/gi,
+    '_'
+  );
+  const modelId = `nodejs_samples_tests_models_${uuid.v4()}`.replace(
+    /-/gi,
+    '_'
+  );
 
   before(async () => {
     const query = `CREATE OR REPLACE MODEL \`${datasetId}.${modelId}\`
@@ -91,8 +97,14 @@ describe('Models', () => {
 });
 
 describe('Delete Model', () => {
-  const datasetId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
-  const modelId = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
+  const datasetId = `nodejs_samples_tests_models_delete_${uuid.v4()}`.replace(
+    /-/gi,
+    '_'
+  );
+  const modelId = `nodejs_samples_tests_models_delete_${uuid.v4()}`.replace(
+    /-/gi,
+    '_'
+  );
 
   before(async () => {
     const query = `CREATE OR REPLACE MODEL \`${datasetId}.${modelId}\`
diff --git a/samples/test/queries.test.js b/samples/test/queries.test.js
index a1450885..dbd03d1b 100644
--- a/samples/test/queries.test.js
+++ b/samples/test/queries.test.js
@@ -22,7 +22,8 @@ const uuid = require('uuid');
 const {BigQuery} = require('@google-cloud/bigquery');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
-const generateUuid = () => `gcloud-tests-${uuid.v4()}`.replace(/-/gi, '_');
+const generateUuid = () =>
+  `nodejs_samples_tests_queries_${uuid.v4()}`.replace(/-/gi, '_');
 const datasetId = generateUuid();
 const tableId = generateUuid();
 const destTableId = generateUuid();
diff --git a/samples/test/quickstart.test.js b/samples/test/quickstart.test.js
index 311fc40b..4428a822 100644
--- a/samples/test/quickstart.test.js
+++ b/samples/test/quickstart.test.js
@@ -25,7 +25,10 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 const bigquery = new BigQuery();
 
 describe('Quickstart', () => {
-  const datasetName = `gcloud_tests_${uuid.v4()}`.replace(/-/gi, '_');
+  const datasetName = `nodejs_samples_tests_quickstart_${uuid.v4()}`.replace(
+    /-/gi,
+    '_'
+  );
 
   after(async () => {
     await bigquery.dataset(datasetName).delete({force: true});
diff --git a/samples/test/tables.test.js b/samples/test/tables.test.js
index 6797164f..394fcb08 100644
--- a/samples/test/tables.test.js
+++ b/samples/test/tables.test.js
@@ -25,7 +25,8 @@ const {BigQuery} = require('@google-cloud/bigquery');
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
 const storage = new Storage();
-const generateUuid = () => `gcloud-tests-${uuid.v4()}`.replace(/-/gi, '_');
+const generateUuid = () =>
+  `nodejs_samples_tests_${uuid.v4()}`.replace(/-/gi, '_');
 
 const datasetId = generateUuid();
 const srcDatasetId = datasetId;