Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

fix: Removed unneeded parse #480

Merged
merged 1 commit into from Jan 15, 2021

Conversation

ivanmkc
Copy link
Contributor

@ivanmkc ivanmkc commented Jan 15, 2021

The arguments need to be strings as that's how the test passes them to the sample function.

Fixes https://b.corp.google.com/issues/174563161

@ivanmkc ivanmkc requested review from a team as code owners January 15, 2021 16:05
@product-auto-label product-auto-label bot added the api: automl Issues related to the googleapis/nodejs-automl API. label Jan 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #480 (5114364) into master (3deea49) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files           9        9           
  Lines       10000    10000           
  Branches      356      356           
=======================================
  Hits         9867     9867           
  Misses        129      129           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3deea49...5114364. Read the comment docs.

@ivanmkc
Copy link
Contributor Author

ivanmkc commented Jan 15, 2021

I think it'll be cleaner to rewrite the test to pass in native JSON, but not sure how to do that.

@lucaswadedavis lucaswadedavis merged commit 3d9aa88 into googleapis:master Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: automl Issues related to the googleapis/nodejs-automl API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants