Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

feat!: drop node8 support, support for async iterators #364

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

alexander-fenster
Copy link
Contributor

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #364 into master will increase coverage by 8.38%.
The diff coverage is 99.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   89.71%   98.09%   +8.38%     
==========================================
  Files           7        7              
  Lines        8011     8938     +927     
  Branches      253      335      +82     
==========================================
+ Hits         7187     8768    +1581     
+ Misses        820      166     -654     
  Partials        4        4              
Impacted Files Coverage Δ
src/v1beta1/auto_ml_client.ts 98.37% <ø> (+7.26%) ⬆️
src/v1/auto_ml_client.ts 98.21% <99.24%> (+6.62%) ⬆️
src/v1/prediction_service_client.ts 97.16% <100.00%> (+10.70%) ⬆️
src/v1beta1/prediction_service_client.ts 97.46% <100.00%> (+14.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a628b...32b36cb. Read the comment docs.

@bcoe bcoe merged commit 156ff6f into master Apr 1, 2020
@bcoe bcoe deleted the finally-drop-node8 branch April 1, 2020 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants