Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

feat: added samples for api-endpoints #259

Merged
merged 3 commits into from
Oct 30, 2019
Merged

feat: added samples for api-endpoints #259

merged 3 commits into from
Oct 30, 2019

Conversation

bradmiro
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2019
@bradmiro bradmiro requested a review from bcoe October 30, 2019 16:45
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files           2        2           
  Lines           7        7           
=======================================
  Hits            5        5           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5cd22...e69d442. Read the comment docs.

@bradmiro bradmiro changed the title feat: Added samples for api-endpoints feat: added samples for api-endpoints Oct 30, 2019
@bradmiro
Copy link
Contributor Author

Samples test fail -> The test that's failing (the new one) passed locally. The dataset is in our client libraries project

Docs fail -> there's a broken link that points to a file that is included with this PR. Should be fixed after merging.

@bcoe bcoe closed this Oct 30, 2019
@bcoe bcoe deleted the api-endpoints branch October 30, 2019 19:09
@bcoe bcoe restored the api-endpoints branch October 30, 2019 19:20
@bcoe bcoe reopened this Oct 30, 2019
@bcoe
Copy link
Contributor

bcoe commented Oct 30, 2019

@bradmiro by default the project we use for Node.js tests is long-door-651, is there a chance it needs to have this feature enabled?

@bradmiro
Copy link
Contributor Author

bradmiro commented Oct 30, 2019

@bcoe I used a service account created in long-door-651 for testing. Hmm...

Edit: fixed :)

@bradmiro bradmiro merged commit 550ffb6 into master Oct 30, 2019
@bradmiro bradmiro deleted the api-endpoints branch October 30, 2019 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants