Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

fix: parse CSV correctly #198

Merged
merged 2 commits into from
Jun 11, 2019
Merged

fix: parse CSV correctly #198

merged 2 commits into from
Jun 11, 2019

Conversation

leahecole
Copy link
Contributor

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2019
@leahecole
Copy link
Contributor Author

I'll be keeping an eye on these tests - they don't pass locally, but I'm not sure if it's because my env variables are wrong

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #198   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54bfc9...d15ce4e. Read the comment docs.

@leahecole
Copy link
Contributor Author

Ping if you need internal bug numbers

Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this sample!

@leahecole leahecole merged commit 8c0eb1c into master Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants