fix: function's returns are missing #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
alexander-fenster
approved these changes
May 20, 2020
There was a problem hiding this comment.
LGTM with nit, but let's also wait for @JustinBeckwith since it's his repo :)
JustinBeckwith
approved these changes
May 20, 2020
|
Thanks for reviewing. 👍 |
|
Looks like I don't have access to merge the pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: client library's generated document miss functions' returns description.
Cause:
returns.tmplhas never been referred before.Fix:
returns.tmplinmethod.tmpl<table>like params and propers to render returnsResult:
