This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
feat(v1): add v1 client #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kolea2
reviewed
Mar 16, 2020
| private static volatile io.grpc.MethodDescriptor< | ||
| com.google.webrisk.v1beta1.SearchHashesRequest, | ||
| com.google.webrisk.v1beta1.SearchHashesResponse> | ||
| getSearchHashesMethod; | ||
|
|
||
| @io.grpc.ExperimentalApi("https://github.com/grpc/grpc-java/issues/1901") | ||
| @io.grpc.stub.annotations.RpcMethod( |
There was a problem hiding this comment.
just want to confirm these are intended changes as part of adding a v1 client?
There was a problem hiding this comment.
This is an artifact of switching to the bazel generator (grpc plugin update). I can separate this into a different PR
There was a problem hiding this comment.
Your call, just wanted to confirm! I'll approve this PR, feel free to separate out if needed
There was a problem hiding this comment.
Removed the v1beta1 stuff and will do it separately for a cleaner commit history
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
============================================
+ Coverage 67.9% 69.01% +1.11%
- Complexity 38 81 +43
============================================
Files 6 12 +6
Lines 243 526 +283
Branches 1 2 +1
============================================
+ Hits 165 363 +198
- Misses 77 160 +83
- Partials 1 3 +2
Continue to review full report at Codecov.
|
kolea2
approved these changes
Mar 16, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.33.0](https://www.github.com/googleapis/java-webrisk/compare/v0.32.1...v0.33.0) (2020-03-16) ### Features * **v1:** add v1 client ([#84](https://www.github.com/googleapis/java-webrisk/issues/84)) ([4d88859](https://www.github.com/googleapis/java-webrisk/commit/4d888599519827c8d5a5a6199d711d70128bf61c)) ### Dependencies * update core dependencies ([#80](https://www.github.com/googleapis/java-webrisk/issues/80)) ([d80edde](https://www.github.com/googleapis/java-webrisk/commit/d80eddeb20c8ac08a3e36e3ce0b4e8af57cf72a6)) * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([46c6241](https://www.github.com/googleapis/java-webrisk/commit/46c6241895c810a285d60110e3eeed14d9cc3e2a)) * update dependency io.grpc:grpc-bom to v1.27.1 ([8dee7e8](https://www.github.com/googleapis/java-webrisk/commit/8dee7e81e10526540cb3aa3655a7b2e110513e9b)) ### Documentation * **regen:** update sample code to set total timeout, add API client header test ([d998db4](https://www.github.com/googleapis/java-webrisk/commit/d998db45f56e36513bfde3338e22fd798efaa742)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, switch to bazel generator