Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

fix: replace get("model") with translationPb.getModel() #242

Merged
merged 2 commits into from Jul 16, 2020
Merged

fix: replace get("model") with translationPb.getModel() #242

merged 2 commits into from Jul 16, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jul 7, 2020

Fixes #240

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020
@athakor athakor requested a review from chingor13 July 7, 2020 12:35
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited

Codecov Report

Merging #242 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     69.42%   69.48%   +0.05%     
- Complexity      219      220       +1     
============================================
  Files            23       23              
  Lines          1678     1678              
  Branches         46       46              
============================================
+ Hits           1165     1166       +1     
+ Misses          468      467       -1     
  Partials         45       45
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/translate/Translation.java 85.18% <100.00%> (+3.70%) 10.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44df12e...03b4baa. Read the comment docs.

@athakor athakor requested a review from a team July 8, 2020 06:31
@athakor
Copy link
Contributor Author

athakor commented Jul 15, 2020

@googleapis/yoshi-java gentle ping

@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 15, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 15, 2020
@chingor13 chingor13 changed the title feat: replace get("model") with translationPb.getModel() fix: replace get("model") with translationPb.getModel() Jul 16, 2020
@chingor13
Copy link
Contributor

chingor13 commented Jul 16, 2020 •
edited

Can you merge from master to get the latest CI config?

Edit: actually, I can do it

@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 97f9664 into googleapis:master Jul 16, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 11, 2020
@release-please
chore: release 1.95.1 (#238)
36575ca 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.95.1](https://www.github.com/googleapis/java-translate/compare/v1.95.0...v1.95.1) (2020-08-10)


### Bug Fixes

* replace get("model") with translationPb.getModel() ([#242](https://www.github.com/googleapis/java-translate/issues/242)) ([97f9664](https://www.github.com/googleapis/java-translate/commit/97f966404a115a5acb36c85fddb71a5b7c72b2e8)), closes [#240](https://www.github.com/googleapis/java-translate/issues/240)
* use rest api for detect and listSupportedLanguages ([#243](https://www.github.com/googleapis/java-translate/issues/243)) ([448f307](https://www.github.com/googleapis/java-translate/commit/448f307cb5f88ae171680442589e1d19d9a4e189)), closes [#241](https://www.github.com/googleapis/java-translate/issues/241)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#237](https://www.github.com/googleapis/java-translate/issues/237)) ([6befa32](https://www.github.com/googleapis/java-translate/commit/6befa32053912c84629d973a668b10316fdfde1b))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#244](https://www.github.com/googleapis/java-translate/issues/244)) ([5ec2720](https://www.github.com/googleapis/java-translate/commit/5ec27208fcfbf09c603070aa4722cb3b8d0e77dc))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#254](https://www.github.com/googleapis/java-translate/issues/254)) ([f595652](https://www.github.com/googleapis/java-translate/commit/f59565262faf8893962d6bb673d1dc5ece87f15a))


### Documentation

* corrects spelling of build dependency adds backticks in docstring to smooth doc generation ([#251](https://www.github.com/googleapis/java-translate/issues/251)) ([8e39d83](https://www.github.com/googleapis/java-translate/commit/8e39d8384b4b6f6ebf9823f6087a7aedb356d5e5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
4 participants
@athakor @chingor13 @googlebot @yoshi-kokoro