From 97f966404a115a5acb36c85fddb71a5b7c72b2e8 Mon Sep 17 00:00:00 2001
From: Ajit Thakor <49403056+athakor@users.noreply.github.com>
Date: Thu, 16 Jul 2020 23:36:17 +0530
Subject: [PATCH] fix: replace get("model") with translationPb.getModel()
 (#242)

Fixes #240
---
 .../main/java/com/google/cloud/translate/Translation.java   | 3 +--
 .../java/com/google/cloud/translate/TranslationTest.java    | 6 +++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java
index 8aa77ce7..8522921b 100644
--- a/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java
+++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java
@@ -104,10 +104,9 @@ public final boolean equals(Object obj) {
   }
 
   static Translation fromPb(TranslationsResource translationPb) {
-    // TODO remove get("model") as soon as REST apiary supports model
     return new Translation(
         translationPb.getTranslatedText(),
         translationPb.getDetectedSourceLanguage(),
-        (String) translationPb.get("model"));
+        translationPb.getModel());
   }
 }
diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java
index 167d4488..292dcaab 100644
--- a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java
+++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java
@@ -25,16 +25,19 @@ public class TranslationTest {
 
   private static final String TRANSLATED_TEXT = "Hello world";
   private static final String SOURCE_LANGUAGE = "en";
+  private static final String MODEL = "nmt";
   private static final TranslationsResource TRANSLATION_PB =
       new TranslationsResource()
           .setTranslatedText(TRANSLATED_TEXT)
-          .setDetectedSourceLanguage(SOURCE_LANGUAGE);
+          .setDetectedSourceLanguage(SOURCE_LANGUAGE)
+          .setModel(MODEL);
   private static final Translation TRANSLATION = Translation.fromPb(TRANSLATION_PB);
 
   @Test
   public void testFromPb() {
     assertEquals(TRANSLATED_TEXT, TRANSLATION.getTranslatedText());
     assertEquals(SOURCE_LANGUAGE, TRANSLATION.getSourceLanguage());
+    assertEquals(MODEL, TRANSLATION.getModel());
     compareTranslation(TRANSLATION, Translation.fromPb(TRANSLATION_PB));
   }
 
@@ -42,6 +45,7 @@ private void compareTranslation(Translation expected, Translation value) {
     assertEquals(expected, value);
     assertEquals(expected.getTranslatedText(), value.getTranslatedText());
     assertEquals(expected.getSourceLanguage(), value.getSourceLanguage());
+    assertEquals(expected.getModel(), value.getModel());
     assertEquals(expected.hashCode(), value.hashCode());
     assertEquals(expected.toString(), value.toString());
   }